[
https://issues.apache.org/jira/browse/HIVE-26701?focusedWorklogId=827321&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-827321
]
ASF GitHub Bot logged work on HIVE-26701:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Nov/22 03:22
Start Date: 19/Nov/22 03:22
Worklog Time Spent: 10m
Work Description: dengzhhu653 commented on code in PR #3773:
URL: https://github.com/apache/hive/pull/3773#discussion_r1027026142
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/PersistenceManagerProvider.java:
##########
@@ -251,11 +277,14 @@ private static PersistenceManagerFactory
initPMF(Configuration conf, boolean for
if (dsp == null) {
pmf = JDOHelper.getPersistenceManagerFactory(dsProp);
} else {
- try {
+ String sourceName = forCompactor ? "objectstore-compactor" :
"objectstore";
+ try (DataSourceProvider.DataSourceNameConfigurator configurator =
+ new DataSourceProvider.DataSourceNameConfigurator(conf,
sourceName)) {
Review Comment:
yes, the name acts as a prefix to the metric, such as:
> "objectstore-secondary.pool.ActiveConnections" : {
"value" : 0
},
"objectstore-secondary.pool.IdleConnections" : {
"value" : 2
},
"objectstore-secondary.pool.PendingConnections" : {
"value" : 0
},
"objectstore-secondary.pool.TotalConnections" : {
"value" : 2
},
"objectstore.pool.ActiveConnections" : {
"value" : 0
},
"objectstore.pool.IdleConnections" : {
"value" : 10
},
"objectstore.pool.PendingConnections" : {
"value" : 0
},
"objectstore.pool.TotalConnections" : {
"value" : 10
}
Issue Time Tracking
-------------------
Worklog Id: (was: 827321)
Time Spent: 1h (was: 50m)
> Enable metrics for Database connection pools(1 & 2) used by ObjectStore in HMS
> ------------------------------------------------------------------------------
>
> Key: HIVE-26701
> URL: https://issues.apache.org/jira/browse/HIVE-26701
> Project: Hive
> Issue Type: Bug
> Components: Standalone Metastore
> Reporter: Taraka Rama Rao Lethavadla
> Assignee: Zhihua Deng
> Priority: Major
> Labels: hive-4.0.0-must, pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> We have metrics enabled for database connection pools(3 & 4) used in
> TxnHandler. We don't have the same for pools(1 & 2) used by ObjectStore
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
