[
https://issues.apache.org/jira/browse/HIVE-26701?focusedWorklogId=827322&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-827322
]
ASF GitHub Bot logged work on HIVE-26701:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Nov/22 03:27
Start Date: 19/Nov/22 03:27
Worklog Time Spent: 10m
Work Description: dengzhhu653 commented on code in PR #3773:
URL: https://github.com/apache/hive/pull/3773#discussion_r1027026693
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/PersistenceManagerProvider.java:
##########
@@ -251,11 +277,14 @@ private static PersistenceManagerFactory
initPMF(Configuration conf, boolean for
if (dsp == null) {
pmf = JDOHelper.getPersistenceManagerFactory(dsProp);
} else {
- try {
+ String sourceName = forCompactor ? "objectstore-compactor" :
"objectstore";
Review Comment:
The metrics of the pool would be something like
{pool_name}.pool.{metric_name}, added a test:
https://github.com/apache/hive/blob/77ea96e25d01de3546c29311eadd342318b2a06a/itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreMetrics.java#L162-L171
Issue Time Tracking
-------------------
Worklog Id: (was: 827322)
Time Spent: 1h 10m (was: 1h)
> Enable metrics for Database connection pools(1 & 2) used by ObjectStore in HMS
> ------------------------------------------------------------------------------
>
> Key: HIVE-26701
> URL: https://issues.apache.org/jira/browse/HIVE-26701
> Project: Hive
> Issue Type: Bug
> Components: Standalone Metastore
> Reporter: Taraka Rama Rao Lethavadla
> Assignee: Zhihua Deng
> Priority: Major
> Labels: hive-4.0.0-must, pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> We have metrics enabled for database connection pools(3 & 4) used in
> TxnHandler. We don't have the same for pools(1 & 2) used by ObjectStore
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
