[
https://issues.apache.org/jira/browse/HIVE-26716?focusedWorklogId=828934&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-828934
]
ASF GitHub Bot logged work on HIVE-26716:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Nov/22 12:53
Start Date: 25/Nov/22 12:53
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #3746:
URL: https://github.com/apache/hive/pull/3746#discussion_r1032427653
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java:
##########
@@ -380,7 +394,7 @@ protected Boolean findNextCompactionAndExecute(boolean
collectGenericStats, bool
compactionTxn.wasSuccessful();
return false;
}
- if (!ci.isMajorCompaction() &&
!isMinorCompactionSupported(t.getParameters(), dir)) {
+ if (ci.type.equals(CompactionType.MINOR) &&
!isMinorCompactionSupported(t.getParameters(), dir)) {
Review Comment:
why can't we have helper method?
Issue Time Tracking
-------------------
Worklog Id: (was: 828934)
Time Spent: 9h 10m (was: 9h)
> Query based Rebalance compaction on full acid tables
> ----------------------------------------------------
>
> Key: HIVE-26716
> URL: https://issues.apache.org/jira/browse/HIVE-26716
> Project: Hive
> Issue Type: Sub-task
> Components: Hive
> Reporter: László Végh
> Assignee: László Végh
> Priority: Major
> Labels: ACID, compaction, pull-request-available
> Time Spent: 9h 10m
> Remaining Estimate: 0h
>
> Support rebalancing compaction on fully ACID tables.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
