[
https://issues.apache.org/jira/browse/HIVE-26716?focusedWorklogId=828945&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-828945
]
ASF GitHub Bot logged work on HIVE-26716:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Nov/22 13:01
Start Date: 25/Nov/22 13:01
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #3746:
URL: https://github.com/apache/hive/pull/3746#discussion_r1032434116
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java:
##########
@@ -144,20 +153,22 @@ public void init(AtomicBoolean stop) throws Exception {
/**
* Determine if compaction can run in a specified directory.
- * @param isMajorCompaction type of compaction.
+ * @param ci {@link CompactionInfo}
* @param dir the delta directory
* @param sd resolved storage descriptor
* @return true, if compaction can run.
*/
- static boolean isEnoughToCompact(boolean isMajorCompaction, AcidDirectory
dir,
- StorageDescriptor sd) {
+ static boolean isEnoughToCompact(CompactionInfo ci, AcidDirectory dir,
StorageDescriptor sd) {
int deltaCount = dir.getCurrentDirectories().size();
int origCount = dir.getOriginalFiles().size();
StringBuilder deltaInfo = new StringBuilder().append(deltaCount);
boolean isEnoughToCompact;
- if (isMajorCompaction) {
+ if (ci.type.equals(CompactionType.REBALANCE)) {
+ //For now, we are allowing rebalance compaction regardless of the table
state. Thresholds will be added later.
Review Comment:
add TODO: ....
Issue Time Tracking
-------------------
Worklog Id: (was: 828945)
Time Spent: 10h 20m (was: 10h 10m)
> Query based Rebalance compaction on full acid tables
> ----------------------------------------------------
>
> Key: HIVE-26716
> URL: https://issues.apache.org/jira/browse/HIVE-26716
> Project: Hive
> Issue Type: Sub-task
> Components: Hive
> Reporter: László Végh
> Assignee: László Végh
> Priority: Major
> Labels: ACID, compaction, pull-request-available
> Time Spent: 10h 20m
> Remaining Estimate: 0h
>
> Support rebalancing compaction on fully ACID tables.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
