[
https://issues.apache.org/jira/browse/HIVE-26716?focusedWorklogId=829264&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-829264
]
ASF GitHub Bot logged work on HIVE-26716:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Nov/22 10:49
Start Date: 28/Nov/22 10:49
Worklog Time Spent: 10m
Work Description: veghlaci05 commented on code in PR #3746:
URL: https://github.com/apache/hive/pull/3746#discussion_r1033390346
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/MRCompactor.java:
##########
@@ -261,7 +285,7 @@ public void run(HiveConf conf, String jobName, Table t,
Partition p, StorageDesc
StringableList dirsToSearch = new StringableList();
Path baseDir = null;
- if (ci.isMajorCompaction()) {
+ if (CompactionType.MAJOR.equals(ci.type)) {
Review Comment:
There were several parts of the code which worked in a way liek below:
`
if (!ci.isMajorCompaction()) {
//Assuming it is minor compaction but it is no longer true!!!
}
`
To enforce re-checking all occurences and to prevent adding such wrong
conditions in the future I decided to remove the function.
Issue Time Tracking
-------------------
Worklog Id: (was: 829264)
Time Spent: 12.5h (was: 12h 20m)
> Query based Rebalance compaction on full acid tables
> ----------------------------------------------------
>
> Key: HIVE-26716
> URL: https://issues.apache.org/jira/browse/HIVE-26716
> Project: Hive
> Issue Type: Sub-task
> Components: Hive
> Reporter: László Végh
> Assignee: László Végh
> Priority: Major
> Labels: ACID, compaction, pull-request-available
> Time Spent: 12.5h
> Remaining Estimate: 0h
>
> Support rebalancing compaction on fully ACID tables.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
