[
https://issues.apache.org/jira/browse/HIVE-26716?focusedWorklogId=828958&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-828958
]
ASF GitHub Bot logged work on HIVE-26716:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Nov/22 13:26
Start Date: 25/Nov/22 13:26
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #3746:
URL: https://github.com/apache/hive/pull/3746#discussion_r1032295454
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorFactory.java:
##########
@@ -28,17 +30,23 @@
/**
* Simple factory class, which returns an instance of {@link QueryCompactor}.
*/
-final class QueryCompactorFactory {
- static final private Logger LOG =
LoggerFactory.getLogger(QueryCompactorFactory.class.getName());
+public final class CompactorFactory {
+ static final private Logger LOG =
LoggerFactory.getLogger(CompactorFactory.class.getName());
+
+ private static final CompactorFactory INSTANCE = new CompactorFactory();
Review Comment:
why do you need an instance of the factory? check Factory Design Pattern
Issue Time Tracking
-------------------
Worklog Id: (was: 828958)
Time Spent: 11h 50m (was: 11h 40m)
> Query based Rebalance compaction on full acid tables
> ----------------------------------------------------
>
> Key: HIVE-26716
> URL: https://issues.apache.org/jira/browse/HIVE-26716
> Project: Hive
> Issue Type: Sub-task
> Components: Hive
> Reporter: László Végh
> Assignee: László Végh
> Priority: Major
> Labels: ACID, compaction, pull-request-available
> Time Spent: 11h 50m
> Remaining Estimate: 0h
>
> Support rebalancing compaction on fully ACID tables.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
