[
https://issues.apache.org/jira/browse/HIVE-26794?focusedWorklogId=830494&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-830494
]
ASF GitHub Bot logged work on HIVE-26794:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Dec/22 01:51
Start Date: 02/Dec/22 01:51
Worklog Time Spent: 10m
Work Description: dengzhhu653 commented on PR #3817:
URL: https://github.com/apache/hive/pull/3817#issuecomment-1334663492
yea, I think I miss it.
> @dengzhhu653 , thank you for the patch. I think this looks like a good
idea overall. I just entered a minor comment about a possible typo.
>
> However, we are also dependent on the connection pool for some other
capabilities. For example, both
[DbCPDataSourceProvider](https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/datasource/DbCPDataSourceProvider.java#L103)
and
[HikariCPDataSourceProvider](https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/datasource/HikariCPDataSourceProvider.java#L76)
apply a connection timeout. After the switch to `NoPoolConnectionPool`, would
we no longer be enforcing a connection timeout?
Good catch, it makes sense to enforce a connection timeout. Thank you for
the suggestion!
Issue Time Tracking
-------------------
Worklog Id: (was: 830494)
Time Spent: 1h 10m (was: 1h)
> Explore changing TxnHandler#connPoolMutex to NoPoolConnectionPool
> -----------------------------------------------------------------
>
> Key: HIVE-26794
> URL: https://issues.apache.org/jira/browse/HIVE-26794
> Project: Hive
> Issue Type: Improvement
> Components: Standalone Metastore
> Reporter: Zhihua Deng
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Instead of creating a fixed size connection pool for TxnHandler#MutexAPI, the
> pool can be assigned to NoPoolConnectionPool due to:
> * TxnHandler#MutexAPI is primarily designed to provide coarse-grained mutex
> support to maintenance tasks running inside the Metastore, these tasks are
> not user faced;
> * A fixed size connection pool as same as the pool used in ObjectStore is a
> waste for other non leaders in the warehouse;
> The NoPoolConnectionPool provides connection on demand, and
> TxnHandler#MutexAPI only uses getConnection method to fetch a connection from
> the pool, so it's doable to change the pool to NoPoolConnectionPool, this
> would make the HMS more scaleable.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
