[ 
https://issues.apache.org/jira/browse/HIVE-26569?focusedWorklogId=831501&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-831501
 ]

ASF GitHub Bot logged work on HIVE-26569:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 06/Dec/22 17:07
            Start Date: 06/Dec/22 17:07
    Worklog Time Spent: 10m 
      Work Description: abstractdog commented on code in PR #3626:
URL: https://github.com/apache/hive/pull/3626#discussion_r1041237612


##########
llap-client/src/java/org/apache/hadoop/hive/llap/security/LlapTokenClient.java:
##########
@@ -117,10 +121,72 @@ private Token<LlapTokenIdentifier> 
extractToken(ByteString tokenBytes) throws IO
 
   private ByteString getTokenBytes(final String appId) throws IOException, 
ServiceException {
     assert clientInstance != null;
+    if (currentToken != null) {
+      try {
+        return fetchTokenWithCurrentToken(appId);
+      } catch (Exception e) {
+        LOG.error("IOException while getting delgation token, trying with 
kerberos login", e);

Review Comment:
   I agree, actually I'm targeting IOException and ServiceException here, I'm 
about to narrow the scope
   if any other problem (exception type) comes here later that can be solved 
with kerberos re-login, we can add it
   
   fixing typo





Issue Time Tracking
-------------------

    Worklog Id:     (was: 831501)
    Time Spent: 3h 40m  (was: 3.5h)

> Support renewal and recreation of LLAP_TOKENs
> ---------------------------------------------
>
>                 Key: HIVE-26569
>                 URL: https://issues.apache.org/jira/browse/HIVE-26569
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: László Bodor
>            Assignee: László Bodor
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 3h 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to