[
https://issues.apache.org/jira/browse/HIVE-26569?focusedWorklogId=831747&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-831747
]
ASF GitHub Bot logged work on HIVE-26569:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Dec/22 13:03
Start Date: 07/Dec/22 13:03
Worklog Time Spent: 10m
Work Description: ayushtkn commented on code in PR #3626:
URL: https://github.com/apache/hive/pull/3626#discussion_r1042178119
##########
llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java:
##########
@@ -403,9 +401,8 @@ public void indicateError(Throwable t) {
+ " appId=" +
currentQueryIdentifierProto.getApplicationIdString()
+ " dagId=" + currentQueryIdentifierProto.getDagIndex()
+ " to node " + node.getHost());
- if (!processSendError(t)) {
- callback.setError(null, t);
- }
+ processSendError(t);
Review Comment:
I meant like that method in the end reaches fetchtoken, and there we are
putting appid as null
Can we not propogate the appId from there and use it here
```
private synchronized void fetchToken() {
LOG.debug("Trying to fetch a new token...");
try {
Token<LlapTokenIdentifier> newToken =
tokenClient.withCurrentToken(new
Token<LlapTokenIdentifier>(token)).getDelegationToken(null); <
Issue Time Tracking
-------------------
Worklog Id: (was: 831747)
Time Spent: 4h 20m (was: 4h 10m)
> Support renewal and recreation of LLAP_TOKENs
> ---------------------------------------------
>
> Key: HIVE-26569
> URL: https://issues.apache.org/jira/browse/HIVE-26569
> Project: Hive
> Issue Type: Improvement
> Reporter: László Bodor
> Assignee: László Bodor
> Priority: Major
> Labels: pull-request-available
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
