[ 
https://issues.apache.org/jira/browse/HIVE-26847?focusedWorklogId=833775&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-833775
 ]

ASF GitHub Bot logged work on HIVE-26847:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 15/Dec/22 11:34
            Start Date: 15/Dec/22 11:34
    Worklog Time Spent: 10m 
      Work Description: deniskuzZ commented on code in PR #3856:
URL: https://github.com/apache/hive/pull/3856#discussion_r1049531780


##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java:
##########
@@ -1127,6 +1127,8 @@ public enum ConfVars {
       "command should handle partition retention. If enabled, and if a 
specific partition's age exceeded\n" +
       "retention period the partition will be dropped along with data"),
 
+    MATERIALIZED_VIEW_ENABLED("metastore.materialized.view.enabled", 
"metastore.materialized.view.enabled", true,

Review Comment:
   To be honest I don't see the reason why we need this config. Don't create MV 
if you do not need one. 
   Hive has plenty of config params already, it's really hard to navigate, and 
introducing a new feature flag just makes the situation worse.  





Issue Time Tracking
-------------------

    Worklog Id:     (was: 833775)
    Time Spent: 1h 20m  (was: 1h 10m)

> Allow a config to disable creation of Materialized Views
> --------------------------------------------------------
>
>                 Key: HIVE-26847
>                 URL: https://issues.apache.org/jira/browse/HIVE-26847
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Ayush Saxena
>            Assignee: Ayush Saxena
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to