[ 
https://issues.apache.org/jira/browse/HIVE-26847?focusedWorklogId=833779&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-833779
 ]

ASF GitHub Bot logged work on HIVE-26847:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 15/Dec/22 11:49
            Start Date: 15/Dec/22 11:49
    Worklog Time Spent: 10m 
      Work Description: TuroczyX commented on code in PR #3856:
URL: https://github.com/apache/hive/pull/3856#discussion_r1049544884


##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java:
##########
@@ -1127,6 +1127,8 @@ public enum ConfVars {
       "command should handle partition retention. If enabled, and if a 
specific partition's age exceeded\n" +
       "retention period the partition will be dropped along with data"),
 
+    MATERIALIZED_VIEW_ENABLED("metastore.materialized.view.enabled", 
"metastore.materialized.view.enabled", true,

Review Comment:
   > That's definitely not an HMS's responsibility to limit the engine 
functionality. What if we have Impala and Hive and just 1 engine doesn't 
support MV, would we disable it globally?
   
   It has a good point. For this use case the HMS is the tight place, because 
they want to disable it globally. But it has sense 





Issue Time Tracking
-------------------

    Worklog Id:     (was: 833779)
    Time Spent: 1h 50m  (was: 1h 40m)

> Allow a config to disable creation of Materialized Views
> --------------------------------------------------------
>
>                 Key: HIVE-26847
>                 URL: https://issues.apache.org/jira/browse/HIVE-26847
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Ayush Saxena
>            Assignee: Ayush Saxena
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to