[
https://issues.apache.org/jira/browse/HIVE-11495?focusedWorklogId=837187&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-837187
]
ASF GitHub Bot logged work on HIVE-11495:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Jan/23 10:13
Start Date: 05/Jan/23 10:13
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #3908:
URL: https://github.com/apache/hive/pull/3908#discussion_r1062308121
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java:
##########
@@ -3227,6 +3227,15 @@ void commitTxn(CommitTxnRequest rqst)
*/
void abortTxns(List<Long> txnids) throws TException;
+ /**
+ * Abort a list of transactions with additional information of
+ * errorcodes as defined in TxnErrorMsg.java.
+ * @param txnids List of transaction ids
+ * @param errorCode Error code specifying the reason for abort.
+ * @throws TException
+ */
+ void abortTxns(List<Long> txnids, long errorCode) throws TException;
Review Comment:
we should make this method generic and use Request object here as well, see
````
CompactionResponse compact2(CompactionRequest request)
void dropDatabase(DropDatabaseRequest req)
etc
````
Issue Time Tracking
-------------------
Worklog Id: (was: 837187)
Time Spent: 4h 40m (was: 4.5h)
> Add aborted reason to transaction information.
> ----------------------------------------------
>
> Key: HIVE-11495
> URL: https://issues.apache.org/jira/browse/HIVE-11495
> Project: Hive
> Issue Type: Improvement
> Components: Metastore, Transactions
> Affects Versions: 1.0.0
> Reporter: Eugene Koifman
> Assignee: Sourabh Badhya
> Priority: Major
> Labels: pull-request-available
> Time Spent: 4h 40m
> Remaining Estimate: 0h
>
> Add logging messages mentioning the reason to abort the transaction.
> Another reason: Commit can fail due to a conflicting write from another txn
> (since HIVE-13395)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
