[ 
https://issues.apache.org/jira/browse/HIVE-11495?focusedWorklogId=837203&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-837203
 ]

ASF GitHub Bot logged work on HIVE-11495:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 05/Jan/23 10:43
            Start Date: 05/Jan/23 10:43
    Worklog Time Spent: 10m 
      Work Description: deniskuzZ commented on code in PR #3908:
URL: https://github.com/apache/hive/pull/3908#discussion_r1062338001


##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java:
##########
@@ -5144,6 +5159,7 @@ private int abortTxns(Connection dbConn, List<Long> 
txnids, boolean checkHeartbe
       if (MetastoreConf.getBoolVar(conf, 
MetastoreConf.ConfVars.METASTORE_ACIDMETRICS_EXT_ON)) {
         
Metrics.getOrCreateCounter(MetricsConstants.TOTAL_NUM_ABORTED_TXNS).inc(txnids.size());
       }
+      LOG.info("Txns are aborted successfully due to : {}", errorMsg);

Review Comment:
   Could we populate TXN_META_INFO with aborted reason as well?
   see //todo: should make abortTxns() write something into TXNS.TXN_META_INFO 
about this





Issue Time Tracking
-------------------

    Worklog Id:     (was: 837203)
    Time Spent: 6h 20m  (was: 6h 10m)

> Add aborted reason to transaction information.
> ----------------------------------------------
>
>                 Key: HIVE-11495
>                 URL: https://issues.apache.org/jira/browse/HIVE-11495
>             Project: Hive
>          Issue Type: Improvement
>          Components: Metastore, Transactions
>    Affects Versions: 1.0.0
>            Reporter: Eugene Koifman
>            Assignee: Sourabh Badhya
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 6h 20m
>  Remaining Estimate: 0h
>
> Add logging messages mentioning the reason to abort the transaction.
> Another reason: Commit can fail due to a conflicting write from another txn 
> (since HIVE-13395)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to