[
https://issues.apache.org/jira/browse/HIVE-11495?focusedWorklogId=837881&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-837881
]
ASF GitHub Bot logged work on HIVE-11495:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jan/23 10:32
Start Date: 09/Jan/23 10:32
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #3908:
URL: https://github.com/apache/hive/pull/3908#discussion_r1064487148
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java:
##########
@@ -5771,12 +5789,11 @@ public void performTimeOuts() {
close(rs, stmt, null);
int numTxnsAborted = 0;
for(List<Long> batchToAbort : timedOutTxns) {
- if (abortTxns(dbConn, batchToAbort, true, false, false) ==
batchToAbort.size()) {
+ if (abortTxns(dbConn, batchToAbort, true, false, false,
TxnErrorMsg.ABORT_TIMEOUT) == batchToAbort.size()) {
dbConn.commit();
numTxnsAborted += batchToAbort.size();
//todo: add TXNS.COMMENT filed and set it to 'aborted by system
due to timeout'
Collections.sort(batchToAbort);//easier to read logs
- LOG.info("Aborted the following transactions due to timeout: {}",
batchToAbort.toString());
Review Comment:
above sorting was only needed for the logging, once you removed it, it
became redundant, maybe it should be moved to abort method
Issue Time Tracking
-------------------
Worklog Id: (was: 837881)
Time Spent: 10.5h (was: 10h 20m)
> Add aborted reason to transaction information.
> ----------------------------------------------
>
> Key: HIVE-11495
> URL: https://issues.apache.org/jira/browse/HIVE-11495
> Project: Hive
> Issue Type: Improvement
> Components: Metastore, Transactions
> Affects Versions: 1.0.0
> Reporter: Eugene Koifman
> Assignee: Sourabh Badhya
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10.5h
> Remaining Estimate: 0h
>
> Add logging messages mentioning the reason to abort the transaction.
> Another reason: Commit can fail due to a conflicting write from another txn
> (since HIVE-13395)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
