[
https://issues.apache.org/jira/browse/HIVE-11495?focusedWorklogId=837886&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-837886
]
ASF GitHub Bot logged work on HIVE-11495:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jan/23 10:55
Start Date: 09/Jan/23 10:55
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #3908:
URL: https://github.com/apache/hive/pull/3908#discussion_r1064508431
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java:
##########
@@ -5150,6 +5166,7 @@ private int abortTxns(Connection dbConn, List<Long>
txnids, boolean checkHeartbe
if (MetastoreConf.getBoolVar(conf,
MetastoreConf.ConfVars.METASTORE_ACIDMETRICS_EXT_ON)) {
Metrics.getOrCreateCounter(MetricsConstants.TOTAL_NUM_ABORTED_TXNS).inc(txnids.size());
}
+ LOG.warn("Txns are aborted successfully due to : {}. Aborted Transaction
IDs : {}", errorMsg, txnids);
Review Comment:
````
LOG.info("Aborted transactions {} due to {}", txnids, errorMsg);
````
errorMsg should be just text, like "heartbeat time-out"
either update the msg in TxnErrorMsg or use it as a pattern for the string
formatter
````
ABORT_ROLLBACK(50005, "<<<Txn aborted due to>>> rollback"),
````
Issue Time Tracking
-------------------
Worklog Id: (was: 837886)
Time Spent: 11h (was: 10h 50m)
> Add aborted reason to transaction information.
> ----------------------------------------------
>
> Key: HIVE-11495
> URL: https://issues.apache.org/jira/browse/HIVE-11495
> Project: Hive
> Issue Type: Improvement
> Components: Metastore, Transactions
> Affects Versions: 1.0.0
> Reporter: Eugene Koifman
> Assignee: Sourabh Badhya
> Priority: Major
> Labels: pull-request-available
> Time Spent: 11h
> Remaining Estimate: 0h
>
> Add logging messages mentioning the reason to abort the transaction.
> Another reason: Commit can fail due to a conflicting write from another txn
> (since HIVE-13395)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
