[
https://issues.apache.org/jira/browse/HIVE-26882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17676455#comment-17676455
]
Peter Vary commented on HIVE-26882:
-----------------------------------
Hi [~ayushtkn]! Long time, no see. I hope things are going well for you!
Tried to build branch-3 on a new laptop and got this:
{code:java}
$ mvn clean install -DskipTests
[INFO] Scanning for projects...
[..]
[ERROR] Failed to execute goal on project hive-upgrade-acid: Could not resolve
dependencies for project org.apache.hive:hive-upgrade-acid:jar:3.2.0-SNAPSHOT:
Failed to collect dependencies at org.apache.hive:hive-exec:jar:2.3.3 ->
org.apache.calcite:calcite-core:jar:1.10.0 ->
org.pentaho:pentaho-aggdesigner-algorithm:jar:5.1.5-jhyde: Failed to read
artifact descriptor for
org.pentaho:pentaho-aggdesigner-algorithm:jar:5.1.5-jhyde: Could not transfer
artifact org.pentaho:pentaho-aggdesigner-algorithm:pom:5.1.5-jhyde from/to
maven-default-http-blocker (http://0.0.0.0/): Blocked mirror for repositories:
[datanucleus (http://www.datanucleus.org/downloads/maven2, default, releases),
glassfish-repository (http://maven.glassfish.org/content/groups/glassfish,
default, disabled), glassfish-repo-archive
(http://maven.glassfish.org/content/groups/glassfish, default, disabled),
apache.snapshots (http://repository.apache.org/snapshots, default, snapshots),
central (http://repo.maven.apache.org/maven2, default, releases), conjars
(http://conjars.org/repo, default, releases+snapshots)] -> [Help 1]
{code}
Seems like an issue with the removal of the pentaho jar from the repos.
Something similar like [https://github.com/apache/hudi/issues/160]
To try to move forward, I removed the {{upgrade-acid}} from the pom to check if
there are another errors. I used this change:
{code:java}
$ g d
diff --git a/pom.xml b/pom.xml
index e1bbb8193e..2cdc848d8a 100644
--- a/pom.xml
+++ b/pom.xml
@@ -62,7 +62,6 @@
<module>testutils</module>
<module>packaging</module>
<module>standalone-metastore</module>
- <module>upgrade-acid</module>
</modules>
<properties>
@@ -996,11 +995,6 @@
<artifactId>slf4j-api</artifactId>
<version>${slf4j.version}</version>
</dependency>
- <dependency>
- <groupId>org.apache.hive</groupId>
- <artifactId>hive-upgrade-acid</artifactId>
- <version>${project.version}</version>
- </dependency>
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty</artifactId>
{code}
And got this error:
{code:java}
$ mvn clean install -DskipTests
[INFO] Scanning for projects...
[..]
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile (default-compile)
on project hive-service-rpc: Compilation failure: Compilation failure:
[ERROR]
/Users/petervary/dev/hive/service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetTableTypesReq.java:[32,24]
package javax.annotation does not exist
[ERROR]
/Users/petervary/dev/hive/service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetTableTypesReq.java:[37,2]
cannot find symbol
[ERROR] symbol: class Generated
[ERROR]
/Users/petervary/dev/hive/service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TSessionHandle.java:[32,24]
package javax.annotation does not exist
[ERROR]
/Users/petervary/dev/hive/service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TSessionHandle.java:[37,2]
cannot find symbol
[ERROR] symbol: class Generated
[ERROR]
/Users/petervary/dev/hive/service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/THandleIdentifier.java:[32,24]
package javax.annotation does not exist
[ERROR]
/Users/petervary/dev/hive/service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/THandleIdentifier.java:[37,2]
cannot find symbol
[ERROR] symbol: class Generated
[..]
{code}
Could you please help me compile the branch-3?
Thanks,
Peter
> Allow transactional check of Table parameter before altering the Table
> ----------------------------------------------------------------------
>
> Key: HIVE-26882
> URL: https://issues.apache.org/jira/browse/HIVE-26882
> Project: Hive
> Issue Type: Improvement
> Components: Standalone Metastore
> Reporter: Peter Vary
> Assignee: Peter Vary
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> We should add the possibility to transactionally check if a Table parameter
> is changed before altering the table in the HMS.
> This would provide an alternative, less error-prone and faster way to commit
> an Iceberg table, as the Iceberg table currently needs to:
> - Create an exclusive lock
> - Get the table metadata to check if the current snapshot is not changed
> - Update the table metadata
> - Release the lock
> After the change these 4 HMS calls could be substituted with a single alter
> table call.
> Also we could avoid cases where the locks are left hanging by failed processes
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
