[
https://issues.apache.org/jira/browse/HIVE-26882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17676720#comment-17676720
]
Peter Vary commented on HIVE-26882:
-----------------------------------
[~ayushtkn]: Thanks for the help!
I have created the PR, an run the tests.
There are 30 failure, but they are not related.
The tests I have created has been successful:
|[Testing / split-16 / Archive /
testAlterTableExpectedPropertyConcurrent[Embedded]|http://ci.hive.apache.org/job/hive-precommit/job/PR-3943/1/testReport/org.apache.hadoop.hive.metastore.client/TestTablesCreateDropAlterTruncate/Testing___split_16___Archive___testAlterTableExpectedPropertyConcurrent_Embedded_]|
|[Testing / split-16 / Archive /
testAlterTableExpectedPropertyConcurrent[Remote]|http://ci.hive.apache.org/job/hive-precommit/job/PR-3943/1/testReport/org.apache.hadoop.hive.metastore.client/TestTablesCreateDropAlterTruncate/Testing___split_16___Archive___testAlterTableExpectedPropertyConcurrent_Remote_]|
|[Testing / split-16 / Archive /
testAlterTableExpectedPropertyDifferent[Embedded]|http://ci.hive.apache.org/job/hive-precommit/job/PR-3943/1/testReport/org.apache.hadoop.hive.metastore.client/TestTablesCreateDropAlterTruncate/Testing___split_16___Archive___testAlterTableExpectedPropertyDifferent_Embedded_]|
|[Testing / split-16 / Archive /
testAlterTableExpectedPropertyDifferent[Remote]|http://ci.hive.apache.org/job/hive-precommit/job/PR-3943/1/testReport/org.apache.hadoop.hive.metastore.client/TestTablesCreateDropAlterTruncate/Testing___split_16___Archive___testAlterTableExpectedPropertyDifferent_Remote_]|
|[Testing / split-16 / Archive /
testAlterTableExpectedPropertyMatch[Embedded]|http://ci.hive.apache.org/job/hive-precommit/job/PR-3943/1/testReport/org.apache.hadoop.hive.metastore.client/TestTablesCreateDropAlterTruncate/Testing___split_16___Archive___testAlterTableExpectedPropertyMatch_Embedded_]|
|[Testing / split-16 / Archive /
testAlterTableExpectedPropertyMatch[Remote]|http://ci.hive.apache.org/job/hive-precommit/job/PR-3943/1/testReport/org.apache.hadoop.hive.metastore.client/TestTablesCreateDropAlterTruncate/Testing___split_16___Archive___testAlterTableExpectedPropertyMatch_Remote_]|
[~ayushtkn]: What should be our next steps?
> Allow transactional check of Table parameter before altering the Table
> ----------------------------------------------------------------------
>
> Key: HIVE-26882
> URL: https://issues.apache.org/jira/browse/HIVE-26882
> Project: Hive
> Issue Type: Improvement
> Components: Standalone Metastore
> Reporter: Peter Vary
> Assignee: Peter Vary
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> We should add the possibility to transactionally check if a Table parameter
> is changed before altering the table in the HMS.
> This would provide an alternative, less error-prone and faster way to commit
> an Iceberg table, as the Iceberg table currently needs to:
> - Create an exclusive lock
> - Get the table metadata to check if the current snapshot is not changed
> - Update the table metadata
> - Release the lock
> After the change these 4 HMS calls could be substituted with a single alter
> table call.
> Also we could avoid cases where the locks are left hanging by failed processes
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
