[
https://issues.apache.org/jira/browse/HIVE-26054?focusedWorklogId=840996&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-840996
]
ASF GitHub Bot logged work on HIVE-26054:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Jan/23 09:07
Start Date: 23/Jan/23 09:07
Worklog Time Spent: 10m
Work Description: kasakrisz commented on code in PR #3891:
URL: https://github.com/apache/hive/pull/3891#discussion_r1083790819
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/RowResolver.java:
##########
@@ -481,11 +492,16 @@ public static RowResolver getCombinedRR(RowResolver
leftRR,
public RowResolver duplicate() {
RowResolver resolver = new RowResolver();
resolver.rowSchema = new RowSchema(rowSchema);
- resolver.rslvMap.putAll(rslvMap);
+ for (Map.Entry<String, Map<String, ColumnInfo>> entry :
rslvMap.entrySet()) {
+ resolver.rslvMap.put(entry.getKey(), new
LinkedHashMap<>(entry.getValue()));
+ }
resolver.invRslvMap.putAll(invRslvMap);
resolver.altInvRslvMap.putAll(altInvRslvMap);
resolver.expressionMap.putAll(expressionMap);
resolver.isExprResolver = isExprResolver;
+ for (Map.Entry<String, Map<String, String>> entry :
ambiguousColumns.entrySet()) {
+ resolver.ambiguousColumns.put(entry.getKey(), new
LinkedHashMap<>(entry.getValue()));
+ }
resolver.ambiguousColumns.putAll(ambiguousColumns);
Review Comment:
It's a bug. Good catch.
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/RowResolver.java:
##########
@@ -101,17 +104,25 @@ public ASTNode getExpressionSource(ASTNode node) {
}
public void put(String tab_alias, String col_alias, ColumnInfo colInfo) {
+ if (!putInternal(tab_alias, col_alias, colInfo)) {
+ return;
+ }
+ if (col_alias != null) {
+ colInfo.setAlias(col_alias.toLowerCase());
+ }
+ }
+
+ public boolean putInternal(String tab_alias, String col_alias, ColumnInfo
colInfo) {
Review Comment:
done
Issue Time Tracking
-------------------
Worklog Id: (was: 840996)
Time Spent: 2h 20m (was: 2h 10m)
> Distinct + Groupby with column alias is failing
> -----------------------------------------------
>
> Key: HIVE-26054
> URL: https://issues.apache.org/jira/browse/HIVE-26054
> Project: Hive
> Issue Type: Bug
> Reporter: Naresh P R
> Assignee: Krisztian Kasa
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> After [HIVE-16924|https://issues.apache.org/jira/browse/HIVE-16924], below
> query is failing.
> {code:java}
> create table table1 (col1 bigint, col2 string);
> create table table2 (t2_col1 string);
> Select distinct col1 as alias_col1
> from table1
> where col2 = (SELECT max(t2_col1) as currentdate from table2 limit 1)
> order by col1;
> Error: Error while compiling statement: FAILED: SemanticException Line 0:-1
> Unsupported SubQuery Expression '1': Only SubQuery expressions that are top
> level conjuncts are allowed (state=42000,code=40000) {code}
> Workaround is either remove distinct column alias "alias_col1" or use alias
> in order by.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
