[
https://issues.apache.org/jira/browse/HIVE-26054?focusedWorklogId=841005&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-841005
]
ASF GitHub Bot logged work on HIVE-26054:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Jan/23 09:23
Start Date: 23/Jan/23 09:23
Worklog Time Spent: 10m
Work Description: kasakrisz commented on code in PR #3891:
URL: https://github.com/apache/hive/pull/3891#discussion_r1083809135
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/RowResolver.java:
##########
@@ -81,7 +81,10 @@ public RowResolver() {
public void putExpression(ASTNode node, ColumnInfo colInfo) {
String treeAsString = node.toStringTree();
expressionMap.put(treeAsString, node);
- put("", treeAsString, colInfo);
+ if (!putInternal("", treeAsString, colInfo)) {
+ return;
+ }
+ colInfo.setAlias(treeAsString);
Review Comment:
Inverted since only one line moved into the If block but I think it is a
question code style. I try to avoid moving and indenting several lines into if
blocks when early return is an option.
Issue Time Tracking
-------------------
Worklog Id: (was: 841005)
Time Spent: 2h 40m (was: 2.5h)
> Distinct + Groupby with column alias is failing
> -----------------------------------------------
>
> Key: HIVE-26054
> URL: https://issues.apache.org/jira/browse/HIVE-26054
> Project: Hive
> Issue Type: Bug
> Reporter: Naresh P R
> Assignee: Krisztian Kasa
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> After [HIVE-16924|https://issues.apache.org/jira/browse/HIVE-16924], below
> query is failing.
> {code:java}
> create table table1 (col1 bigint, col2 string);
> create table table2 (t2_col1 string);
> Select distinct col1 as alias_col1
> from table1
> where col2 = (SELECT max(t2_col1) as currentdate from table2 limit 1)
> order by col1;
> Error: Error while compiling statement: FAILED: SemanticException Line 0:-1
> Unsupported SubQuery Expression '1': Only SubQuery expressions that are top
> level conjuncts are allowed (state=42000,code=40000) {code}
> Workaround is either remove distinct column alias "alias_col1" or use alias
> in order by.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
