[ 
https://issues.apache.org/jira/browse/HIVE-26947?focusedWorklogId=841119&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-841119
 ]

ASF GitHub Bot logged work on HIVE-26947:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 23/Jan/23 13:31
            Start Date: 23/Jan/23 13:31
    Worklog Time Spent: 10m 
      Work Description: veghlaci05 commented on code in PR #3955:
URL: https://github.com/apache/hive/pull/3955#discussion_r1084059634


##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java:
##########
@@ -107,6 +108,7 @@ public void run() {
     try {
       do {
         long startedAt = System.currentTimeMillis();
+        boolean err = false;
         launchedJob = true;

Review Comment:
   @deniskuzZ That is because all the catch blocks were setting launchedJob to 
true, or in other words, only the executor.submit() result could set it to 
false. By initializing it with true there was no need to set it in every catch 
block.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 841119)
    Time Spent: 5h 50m  (was: 5h 40m)

> Hive compactor.Worker can respawn connections to HMS at extremely high 
> frequency
> --------------------------------------------------------------------------------
>
>                 Key: HIVE-26947
>                 URL: https://issues.apache.org/jira/browse/HIVE-26947
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Akshat Mathur
>            Assignee: Akshat Mathur
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 5h 50m
>  Remaining Estimate: 0h
>
> After catching the exception generated by the findNextCompactionAndExecute() 
> task, HS2 appears to immediately rerun the task with no delay or backoff.  As 
> a result there are ~3500 connection attempts from HS2 to HMS over just a 5 
> second period in the HS2 log
> The compactor.Worker should wait between failed attempts and maybe do an 
> exponential backoff.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to