[
https://issues.apache.org/jira/browse/HIVE-26947?focusedWorklogId=841136&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-841136
]
ASF GitHub Bot logged work on HIVE-26947:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Jan/23 14:01
Start Date: 23/Jan/23 14:01
Worklog Time Spent: 10m
Work Description: veghlaci05 commented on code in PR #3955:
URL: https://github.com/apache/hive/pull/3955#discussion_r1084093568
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java:
##########
@@ -118,20 +120,33 @@ public void run() {
singleRun.cancel(true);
executor.shutdownNow();
executor = getTimeoutHandlingExecutor();
+ err = true;
} catch (ExecutionException e) {
LOG.info("Exception during executing compaction", e);
+ err = true;
} catch (InterruptedException ie) {
// do not ignore interruption requests
return;
Review Comment:
At this point the thread will end for sure since we are exiting the main
loop. If we restore the interrupted status, InterruptedException will be
re-thrown if the thread gets blocked by sleep/wait etc. I'm not sure about it,
but the msc.close() call in the finally block may result in an
InterruptedException if the threads needs to wait for sth during closing the
Thrift client.
Issue Time Tracking
-------------------
Worklog Id: (was: 841136)
Time Spent: 8h (was: 7h 50m)
> Hive compactor.Worker can respawn connections to HMS at extremely high
> frequency
> --------------------------------------------------------------------------------
>
> Key: HIVE-26947
> URL: https://issues.apache.org/jira/browse/HIVE-26947
> Project: Hive
> Issue Type: Bug
> Reporter: Akshat Mathur
> Assignee: Akshat Mathur
> Priority: Major
> Labels: pull-request-available
> Time Spent: 8h
> Remaining Estimate: 0h
>
> After catching the exception generated by the findNextCompactionAndExecute()
> task, HS2 appears to immediately rerun the task with no delay or backoff. As
> a result there are ~3500 connection attempts from HS2 to HMS over just a 5
> second period in the HS2 log
> The compactor.Worker should wait between failed attempts and maybe do an
> exponential backoff.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
