[
https://issues.apache.org/jira/browse/HIVE-27031?focusedWorklogId=845022&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-845022
]
ASF GitHub Bot logged work on HIVE-27031:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Feb/23 08:15
Start Date: 13/Feb/23 08:15
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #4026:
URL: https://github.com/apache/hive/pull/4026#discussion_r1104119494
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/UpdateDeleteSemanticAnalyzer.java:
##########
@@ -162,8 +188,13 @@ private void reparseAndSuperAnalyze(ASTNode tree, Table
mTable, ASTNode tabNameN
rewrittenCtx.setOperation(Context.Operation.UPDATE);
rewrittenCtx.addDestNamePrefix(1, Context.DestClausePrefix.UPDATE);
} else if (deleting()) {
- rewrittenCtx.setOperation(Context.Operation.DELETE);
- rewrittenCtx.addDestNamePrefix(1, Context.DestClausePrefix.DELETE);
+ if (isOverwrite) {
+ rewrittenCtx.setOperation(Context.Operation.OTHER);
Review Comment:
@ayushtkn, not sure if you got my comment right. I was saying why can we
simply
````
rewrittenCtx.setOperation(Context.Operation.OTHER);
````
if that would set
````
rewrittenCtx.addDestNamePrefix(1, Context.DestClausePrefix.INSERT);
````
in getDestNamePrefix
but, if
````
rewrittenCtx.addDestNamePrefix(1, Context.DestClausePrefix.INSERT);
````
is enough that's OK
Issue Time Tracking
-------------------
Worklog Id: (was: 845022)
Time Spent: 4h 20m (was: 4h 10m)
> Iceberg: Implement Copy-On-Write for Delete Queries
> ---------------------------------------------------
>
> Key: HIVE-27031
> URL: https://issues.apache.org/jira/browse/HIVE-27031
> Project: Hive
> Issue Type: Sub-task
> Reporter: Ayush Saxena
> Assignee: Ayush Saxena
> Priority: Major
> Labels: pull-request-available
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> Implement copy on write mode for deletes for iceberg tables
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
