[
https://issues.apache.org/jira/browse/HIVE-27031?focusedWorklogId=845025&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-845025
]
ASF GitHub Bot logged work on HIVE-27031:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Feb/23 08:23
Start Date: 13/Feb/23 08:23
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #4026:
URL: https://github.com/apache/hive/pull/4026#discussion_r1104126264
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/UpdateDeleteSemanticAnalyzer.java:
##########
@@ -145,11 +162,21 @@ private void reparseAndSuperAnalyze(ASTNode tree, Table
mTable, ASTNode tabNameN
where = (ASTNode)children.get(whereIndex);
assert where.getToken().getType() == HiveParser.TOK_WHERE :
"Expected where clause, but found " + where.getName();
- }
- // Add a sort by clause so that the row ids come out in the correct order
- appendSortBy(rewrittenQueryStr, columnAppender.getSortKeys());
+ if (shouldOverwrite) {
+ assert where.getChildCount() < 2 : "Overwrite mode not supported with
more than 1 children in where clause.";
Review Comment:
Looks like the `assert` keyword is heavily used in SemanticAnalyzer.
Those statements have a well-defined syntax by the standard and the AST
parser builds the tree in a deterministic way.
Maybe it wasn't worth testing this in prod since this is determined at java
compile time and is already covered with end-to-end tests (q tests).
Leaving it up to you ...
Issue Time Tracking
-------------------
Worklog Id: (was: 845025)
Time Spent: 4.5h (was: 4h 20m)
> Iceberg: Implement Copy-On-Write for Delete Queries
> ---------------------------------------------------
>
> Key: HIVE-27031
> URL: https://issues.apache.org/jira/browse/HIVE-27031
> Project: Hive
> Issue Type: Sub-task
> Reporter: Ayush Saxena
> Assignee: Ayush Saxena
> Priority: Major
> Labels: pull-request-available
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> Implement copy on write mode for deletes for iceberg tables
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
