[
https://issues.apache.org/jira/browse/HIVE-27019?focusedWorklogId=847737&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-847737
]
ASF GitHub Bot logged work on HIVE-27019:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Feb/23 07:51
Start Date: 27/Feb/23 07:51
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #4032:
URL: https://github.com/apache/hive/pull/4032#discussion_r1118384775
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/MetaStoreCompactorThread.java:
##########
@@ -57,15 +50,15 @@ public class MetaStoreCompactorThread extends
CompactorThread implements MetaSto
protected TxnStore txnHandler;
protected ScheduledExecutorService cycleUpdaterExecutorService;
-
- private Optional<Cache<String, TBase>> metaCache = Optional.empty();
+ protected CacheContainer cacheContainer;
@Override
public void init(AtomicBoolean stop) throws Exception {
super.init(stop);
// Get our own instance of the transaction handler
txnHandler = TxnUtils.getTxnStore(conf);
+ cacheContainer = new CacheContainer();
Review Comment:
shouldn't it be a singleton? why do we need multiple cache instances for
Initiator & Cleaner?
Issue Time Tracking
-------------------
Worklog Id: (was: 847737)
Time Spent: 10h 40m (was: 10.5h)
> Split Cleaner into separate manageable modular entities
> -------------------------------------------------------
>
> Key: HIVE-27019
> URL: https://issues.apache.org/jira/browse/HIVE-27019
> Project: Hive
> Issue Type: Sub-task
> Reporter: Sourabh Badhya
> Assignee: Sourabh Badhya
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10h 40m
> Remaining Estimate: 0h
>
> As described by the parent task -
> Cleaner can be divided into separate entities like -
> *1) Handler* - This entity fetches the data from the metastore DB from
> relevant tables and converts it into a request entity called CleaningRequest.
> It would also do SQL operations post cleanup (postprocess). Every type of
> cleaning request is provided by a separate handler.
> *2) Filesystem remover* - This entity fetches the cleaning requests from
> various handlers and deletes them according to the cleaning request.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
