[
https://issues.apache.org/jira/browse/HIVE-27019?focusedWorklogId=847924&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-847924
]
ASF GitHub Bot logged work on HIVE-27019:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Feb/23 04:21
Start Date: 28/Feb/23 04:21
Worklog Time Spent: 10m
Work Description: SourabhBadhya commented on code in PR #4032:
URL: https://github.com/apache/hive/pull/4032#discussion_r1119559393
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/MetaStoreCompactorThread.java:
##########
@@ -57,15 +50,15 @@ public class MetaStoreCompactorThread extends
CompactorThread implements MetaSto
protected TxnStore txnHandler;
protected ScheduledExecutorService cycleUpdaterExecutorService;
-
- private Optional<Cache<String, TBase>> metaCache = Optional.empty();
+ protected CacheContainer cacheContainer;
@Override
public void init(AtomicBoolean stop) throws Exception {
super.init(stop);
// Get our own instance of the transaction handler
txnHandler = TxnUtils.getTxnStore(conf);
+ cacheContainer = new CacheContainer();
Review Comment:
As discussed, the cached instances are invalidated both on Initiator and
Cleaner side. There might also be staleness of table object if properties of
the table are changed in the time between Initiator & Cleaner.
Issue Time Tracking
-------------------
Worklog Id: (was: 847924)
Time Spent: 12h (was: 11h 50m)
> Split Cleaner into separate manageable modular entities
> -------------------------------------------------------
>
> Key: HIVE-27019
> URL: https://issues.apache.org/jira/browse/HIVE-27019
> Project: Hive
> Issue Type: Sub-task
> Reporter: Sourabh Badhya
> Assignee: Sourabh Badhya
> Priority: Major
> Labels: pull-request-available
> Time Spent: 12h
> Remaining Estimate: 0h
>
> As described by the parent task -
> Cleaner can be divided into separate entities like -
> *1) Handler* - This entity fetches the data from the metastore DB from
> relevant tables and converts it into a request entity called CleaningRequest.
> It would also do SQL operations post cleanup (postprocess). Every type of
> cleaning request is provided by a separate handler.
> *2) Filesystem remover* - This entity fetches the cleaning requests from
> various handlers and deletes them according to the cleaning request.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
