[
https://issues.apache.org/jira/browse/HIVE-27101?focusedWorklogId=849205&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-849205
]
ASF GitHub Bot logged work on HIVE-27101:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Mar/23 08:06
Start Date: 06/Mar/23 08:06
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #4079:
URL: https://github.com/apache/hive/pull/4079#discussion_r1119727638
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -1179,4 +1179,28 @@ public boolean
shouldOverwrite(org.apache.hadoop.hive.ql.metadata.Table mTable,
}
return COPY_ON_WRITE.equalsIgnoreCase(mode);
}
+
+ @Override
+ public Boolean hasDeleteOperation(org.apache.hadoop.hive.ql.metadata.Table
hmsTable, SnapshotContext since) {
+ TableDesc tableDesc = Utilities.getTableDesc(hmsTable);
+ Table table = IcebergTableUtil.getTable(conf, tableDesc.getProperties());
+ boolean foundSince = false;
+ for (Snapshot snapshot : table.snapshots()) {
+ if (!foundSince) {
+ if (snapshot.snapshotId() == since.getSnapshotId()) {
Review Comment:
is `table.snapshots()` sorted by snapshotId?
Issue Time Tracking
-------------------
Worklog Id: (was: 849205)
Time Spent: 1.5h (was: 1h 20m)
> Support incremental materialized view rebuild when Iceberg source tables have
> insert operation only.
> ----------------------------------------------------------------------------------------------------
>
> Key: HIVE-27101
> URL: https://issues.apache.org/jira/browse/HIVE-27101
> Project: Hive
> Issue Type: Improvement
> Components: Iceberg integration, Materialized views
> Reporter: Krisztian Kasa
> Assignee: Krisztian Kasa
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
