[
https://issues.apache.org/jira/browse/HIVE-27101?focusedWorklogId=849210&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-849210
]
ASF GitHub Bot logged work on HIVE-27101:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Mar/23 08:15
Start Date: 06/Mar/23 08:15
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #4079:
URL: https://github.com/apache/hive/pull/4079#discussion_r1126066261
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/mapreduce/IcebergInputFormat.java:
##########
@@ -116,6 +116,13 @@ private static TableScan createTableScan(Table table,
Configuration conf) {
scan = scan.useSnapshot(snapshotId);
}
+ if (snapshotId == -1) {
+ long snapshotIntervalFrom =
conf.getLong(InputFormatConfig.SNAPSHOT_INTERVAL_FROM, -1);
+ if (snapshotIntervalFrom != -1) {
+ scan = scan.appendsBetween(snapshotIntervalFrom,
table.currentSnapshot().snapshotId());
Review Comment:
this API is deprecated, I don't think we should build something on it. Could
we use `newIncrementalAppendScan`?
Issue Time Tracking
-------------------
Worklog Id: (was: 849210)
Time Spent: 2h 10m (was: 2h)
> Support incremental materialized view rebuild when Iceberg source tables have
> insert operation only.
> ----------------------------------------------------------------------------------------------------
>
> Key: HIVE-27101
> URL: https://issues.apache.org/jira/browse/HIVE-27101
> Project: Hive
> Issue Type: Improvement
> Components: Iceberg integration, Materialized views
> Reporter: Krisztian Kasa
> Assignee: Krisztian Kasa
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
