[ 
https://issues.apache.org/jira/browse/HIVE-27124?focusedWorklogId=850102&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-850102
 ]

ASF GitHub Bot logged work on HIVE-27124:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 09/Mar/23 15:32
            Start Date: 09/Mar/23 15:32
    Worklog Time Spent: 10m 
      Work Description: zabetak commented on code in PR #4101:
URL: https://github.com/apache/hive/pull/4101#discussion_r1131200440


##########
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:
##########
@@ -2366,7 +2366,7 @@ public static enum ConfVars {
         "Whether Hive enables the optimization about converting common join 
into mapjoin based on the input file size. \n" +
         "If this parameter is on, and the sum of size for n-1 of the 
tables/partitions for a n-way join is smaller than the\n" +
         "specified size, the join is directly converted to a mapjoin (there is 
no conditional task)."),
-    HIVE_CONVERT_ANTI_JOIN("hive.auto.convert.anti.join", true,
+    HIVE_CONVERT_ANTI_JOIN("hive.auto.convert.anti.join", false,
         "Whether Hive enables the optimization about converting join with null 
filter to anti join"),

Review Comment:
   I would also add a small warning in the description that turning it to 
`true` may in some cases lead to wrong results or that at this stage it is an 
experimental feature or something along these lines. Without doing so users do 
not know if they should touch the configs or not.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 850102)
    Time Spent: 40m  (was: 0.5h)

> Temporarily disable default usage of anti-join
> ----------------------------------------------
>
>                 Key: HIVE-27124
>                 URL: https://issues.apache.org/jira/browse/HIVE-27124
>             Project: Hive
>          Issue Type: Improvement
>          Components: Hive
>            Reporter: Steve Carlin
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> Temporarily disabling the default usage for antijoin due to wrong results as 
> documented by HIVE-26659



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to