[ 
https://issues.apache.org/jira/browse/HIVE-27124?focusedWorklogId=850113&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-850113
 ]

ASF GitHub Bot logged work on HIVE-27124:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 09/Mar/23 16:11
            Start Date: 09/Mar/23 16:11
    Worklog Time Spent: 10m 
      Work Description: scarlin-cloudera commented on code in PR #4101:
URL: https://github.com/apache/hive/pull/4101#discussion_r1131261309


##########
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:
##########
@@ -2366,7 +2366,7 @@ public static enum ConfVars {
         "Whether Hive enables the optimization about converting common join 
into mapjoin based on the input file size. \n" +
         "If this parameter is on, and the sum of size for n-1 of the 
tables/partitions for a n-way join is smaller than the\n" +
         "specified size, the join is directly converted to a mapjoin (there is 
no conditional task)."),
-    HIVE_CONVERT_ANTI_JOIN("hive.auto.convert.anti.join", true,
+    HIVE_CONVERT_ANTI_JOIN("hive.auto.convert.anti.join", false,
         "Whether Hive enables the optimization about converting join with null 
filter to anti join"),

Review Comment:
   So regarding the first point. I'm kinda feeling like the tests should match 
the default behavior.  I wrote "temporarily" in the description, but not sure 
when that will happen.  I think the tests should match the default behavior.
   
   Regarding the second point, yeah, that's a good idea and I'll add that.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 850113)
    Time Spent: 50m  (was: 40m)

> Temporarily disable default usage of anti-join
> ----------------------------------------------
>
>                 Key: HIVE-27124
>                 URL: https://issues.apache.org/jira/browse/HIVE-27124
>             Project: Hive
>          Issue Type: Improvement
>          Components: Hive
>            Reporter: Steve Carlin
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> Temporarily disabling the default usage for antijoin due to wrong results as 
> documented by HIVE-26659



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to