[
https://issues.apache.org/jira/browse/HIVE-27145?focusedWorklogId=853598&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-853598
]
ASF GitHub Bot logged work on HIVE-27145:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Mar/23 07:40
Start Date: 29/Mar/23 07:40
Worklog Time Spent: 10m
Work Description: kasakrisz commented on PR #4122:
URL: https://github.com/apache/hive/pull/4122#issuecomment-1488093652
@rbalamohan
IIUC `Math` implementation of functions affected by this PR may exploit
specific microprocessor instructions if available in that platform which gives
a better performance but the default implementation just calls the `StrictMath`
version.
The cost of the performance boost is precision.
Example from the PR:
`Degrees(cdecimal1)`
```
-6844.522849943508
```
vs
```
-6844.522849944
```
Should we give up possible performance benefits to favor precision? Could
you please share your thoughts?
Issue Time Tracking
-------------------
Worklog Id: (was: 853598)
Time Spent: 40m (was: 0.5h)
> Use StrictMath for remaining Math functions as followup of HIVE-23133
> ---------------------------------------------------------------------
>
> Key: HIVE-27145
> URL: https://issues.apache.org/jira/browse/HIVE-27145
> Project: Hive
> Issue Type: Task
> Components: UDF
> Reporter: Himanshu Mishra
> Assignee: Himanshu Mishra
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> [HIVE-23133|https://issues.apache.org/jira/browse/HIVE-23133] started using
> {{StrictMath}} for {{cos, exp, log}} UDFs to fix QTests failing as results
> vary based on hardware when using Math library.
> Follow it up by using {{StrictMath}} for other Math functions that can have
> same impact of underlying hardware namely, {{sin, tan, asin, acos, atan,
> sqrt, pow, cbrt}}.
> [JDK-4477961|https://bugs.openjdk.org/browse/JDK-4477961] (in Java 9) changed
> radians and degrees calculation leading to Q Test failures when tests are run
> on Java 9+, fix such tests.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
