[
https://issues.apache.org/jira/browse/HIVE-27145?focusedWorklogId=854908&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-854908
]
ASF GitHub Bot logged work on HIVE-27145:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Apr/23 00:09
Start Date: 05/Apr/23 00:09
Worklog Time Spent: 10m
Work Description: rbalamohan commented on PR #4122:
URL: https://github.com/apache/hive/pull/4122#issuecomment-1496750915
This is specific to JDK 9 issue.
In recent JDKs it is back to the original implementation. i.e strictfp is
removed and it is back to using Math.toDegrees in StrictMath.
https://github.com/openjdk/jdk/commit/0ae4ceb413a7ea92a41cd55cd338f866098eb9b4
_Until we move to the latest JDK, it is fine to make this change._
Note that it will not have any difference in JDK 8 as well, since
StrictMath::toDegrees uses Math::toDegrees/
Issue Time Tracking
-------------------
Worklog Id: (was: 854908)
Time Spent: 1h (was: 50m)
> Use StrictMath for remaining Math functions as followup of HIVE-23133
> ---------------------------------------------------------------------
>
> Key: HIVE-27145
> URL: https://issues.apache.org/jira/browse/HIVE-27145
> Project: Hive
> Issue Type: Task
> Components: UDF
> Reporter: Himanshu Mishra
> Assignee: Himanshu Mishra
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> [HIVE-23133|https://issues.apache.org/jira/browse/HIVE-23133] started using
> {{StrictMath}} for {{cos, exp, log}} UDFs to fix QTests failing as results
> vary based on hardware when using Math library.
> Follow it up by using {{StrictMath}} for other Math functions that can have
> same impact of underlying hardware namely, {{sin, tan, asin, acos, atan,
> sqrt, pow, cbrt}}.
> [JDK-4477961|https://bugs.openjdk.org/browse/JDK-4477961] (in Java 9) changed
> radians and degrees calculation leading to Q Test failures when tests are run
> on Java 9+, fix such tests.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
