[
https://issues.apache.org/jira/browse/HIVE-27177?focusedWorklogId=854150&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-854150
]
ASF GitHub Bot logged work on HIVE-27177:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 31/Mar/23 10:48
Start Date: 31/Mar/23 10:48
Worklog Time Spent: 10m
Work Description: ayushtkn commented on code in PR #4155:
URL: https://github.com/apache/hive/pull/4155#discussion_r1154324502
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/convert/AlterTableConvertOperation.java:
##########
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.ql.ddl.table.convert;
+
+
+import org.apache.hadoop.hive.ql.ddl.DDLOperation;
+import org.apache.hadoop.hive.ql.ddl.DDLOperationContext;
+import org.apache.hadoop.hive.ql.ddl.table.AbstractAlterTableOperation;
+import org.apache.hadoop.hive.ql.metadata.HiveException;
+import org.apache.hadoop.hive.ql.metadata.Partition;
+import org.apache.hadoop.hive.ql.metadata.Table;
+import org.apache.hadoop.hive.ql.parse.SemanticException;
+
+import java.util.Map;
+
+/**
+ * Operation process of ALTER TABLE ... CONVERT command
+ */
+public class AlterTableConvertOperation extends
AbstractAlterTableOperation<AlterTableConvertDesc> {
+
+ public AlterTableConvertOperation(DDLOperationContext context,
AlterTableConvertDesc desc) {
+ super(context, desc);
+ }
+
+ @Override
+ protected void doAlteration(Table table, Partition partition) throws
HiveException {
+ // Add the covert type
+ String convertType = desc.getConvertSpec().getTargetType();
+ if (convertType.equalsIgnoreCase("ICEBERG")) {
+ table.getParameters().put("storage_handler",
"org.apache.iceberg.mr.hive.HiveIcebergStorageHandler");
Review Comment:
Thanx @zhangbutao for the review. I have changed the code to throw exception
in case the table is already of type Iceberg.
Makes sense we need not to do anything in that case, just flag the user that
the table is already iceberg
Issue Time Tracking
-------------------
Worklog Id: (was: 854150)
Time Spent: 50m (was: 40m)
> Add alter table...Convert to Iceberg command
> --------------------------------------------
>
> Key: HIVE-27177
> URL: https://issues.apache.org/jira/browse/HIVE-27177
> Project: Hive
> Issue Type: Improvement
> Reporter: Ayush Saxena
> Assignee: Ayush Saxena
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Add an alter table <tblName> convert to Iceberg [TBLPROPERTIES('','')] to
> convert exiting external tables to iceberg tables
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
