[jira] [Work logged] (HIVE-27177) Add alter table...Convert to Iceberg command

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/HIVE-27177?focusedWorklogId=856078&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-856078
 ]

ASF GitHub Bot logged work on HIVE-27177:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 11/Apr/23 11:05
            Start Date: 11/Apr/23 11:05
    Worklog Time Spent: 10m 
      Work Description: deniskuzZ commented on code in PR #4155:
URL: https://github.com/apache/hive/pull/4155#discussion_r1162652949


##########
iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergMigration.java:
##########
@@ -266,10 +292,14 @@ public void testMigrationFailsForManagedTable() {
             
"('storage_handler'='org.apache.iceberg.mr.hive.HiveIcebergStorageHandler')"));
   }
 
-  private void validateMigration(String tableName) throws TException, 
InterruptedException {
+  private Table validateMigration(String tableName, String tblProperties)

Review Comment:
   can we keep  `validateMigration` with 1 argument, to avoid passing `null` in 
multiple places





Issue Time Tracking
-------------------

    Worklog Id:     (was: 856078)
    Time Spent: 2h 20m  (was: 2h 10m)

> Add alter table...Convert to Iceberg command
> --------------------------------------------
>
>                 Key: HIVE-27177
>                 URL: https://issues.apache.org/jira/browse/HIVE-27177
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Ayush Saxena
>            Assignee: Ayush Saxena
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> Add an alter table <tblName> convert to Iceberg [TBLPROPERTIES('','')] to 
> convert exiting external tables to iceberg tables



--
This message was sent by Atlassian Jira
(v8.20.10#820010)