[
https://issues.apache.org/jira/browse/HIVE-27020?focusedWorklogId=855783&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-855783
]
ASF GitHub Bot logged work on HIVE-27020:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Apr/23 11:56
Start Date: 10/Apr/23 11:56
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #4091:
URL: https://github.com/apache/hive/pull/4091#discussion_r1161658033
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/handler/CompactionCleaner.java:
##########
@@ -337,18 +287,9 @@ private static String idWatermark(CompactionInfo ci) {
return " id=" + ci.id;
}
- private ValidReaderWriteIdList getValidCleanerWriteIdList(CompactionInfo ci,
ValidTxnList validTxnList)
+ private ValidReaderWriteIdList
getValidCleanerWriteIdListForCompactionCleaner(CompactionInfo ci, ValidTxnList
validTxnList)
Review Comment:
why rename here, just override the parent method and call super?
Issue Time Tracking
-------------------
Worklog Id: (was: 855783)
Time Spent: 9h 20m (was: 9h 10m)
> Implement a separate handler to handle aborted transaction cleanup
> ------------------------------------------------------------------
>
> Key: HIVE-27020
> URL: https://issues.apache.org/jira/browse/HIVE-27020
> Project: Hive
> Issue Type: Sub-task
> Reporter: Sourabh Badhya
> Assignee: Sourabh Badhya
> Priority: Major
> Labels: pull-request-available
> Time Spent: 9h 20m
> Remaining Estimate: 0h
>
> As described in the parent task, once the cleaner is separated into different
> entities, implement a separate handler which can create requests for aborted
> transactions cleanup. This would move the aborted transaction cleanup
> exclusively to the cleaner.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
