[ 
https://issues.apache.org/jira/browse/HIVE-27020?focusedWorklogId=855843&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-855843
 ]

ASF GitHub Bot logged work on HIVE-27020:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 10/Apr/23 14:17
            Start Date: 10/Apr/23 14:17
    Worklog Time Spent: 10m 
      Work Description: deniskuzZ commented on code in PR #4091:
URL: https://github.com/apache/hive/pull/4091#discussion_r1161758279


##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnUtils.java:
##########
@@ -60,20 +60,20 @@
 public class TxnUtils {
   private static final Logger LOG = LoggerFactory.getLogger(TxnUtils.class);
 
-  public static ValidTxnList createValidTxnListForCleaner(GetOpenTxnsResponse 
txns, long minOpenTxnGLB) {
-    long highWaterMark = minOpenTxnGLB - 1;
+  public static ValidTxnList 
createValidTxnListForCompactionCleaner(GetOpenTxnsResponse txns, long 
minOpenTxn) {
+    long highWatermark = minOpenTxn - 1;
     long[] abortedTxns = new long[txns.getOpen_txnsSize()];
     BitSet abortedBits = BitSet.valueOf(txns.getAbortedBits());
     int i = 0;
     for(long txnId : txns.getOpen_txns()) {
-      if(txnId > highWaterMark) {
+      if(txnId > highWatermark) {

Review Comment:
   space





Issue Time Tracking
-------------------

    Worklog Id:     (was: 855843)
    Time Spent: 10h 50m  (was: 10h 40m)

> Implement a separate handler to handle aborted transaction cleanup
> ------------------------------------------------------------------
>
>                 Key: HIVE-27020
>                 URL: https://issues.apache.org/jira/browse/HIVE-27020
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Sourabh Badhya
>            Assignee: Sourabh Badhya
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10h 50m
>  Remaining Estimate: 0h
>
> As described in the parent task, once the cleaner is separated into different 
> entities, implement a separate handler which can create requests for aborted 
> transactions cleanup. This would move the aborted transaction cleanup 
> exclusively to the cleaner.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to