[
https://issues.apache.org/jira/browse/HIVE-27172?focusedWorklogId=858987&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-858987
]
ASF GitHub Bot logged work on HIVE-27172:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Apr/23 17:08
Start Date: 25/Apr/23 17:08
Worklog Time Spent: 10m
Work Description: wecharyu commented on code in PR #4150:
URL: https://github.com/apache/hive/pull/4150#discussion_r1176806249
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java:
##########
@@ -402,6 +402,8 @@ public enum ConfVars {
"has an infinite lifetime."),
CLIENT_SOCKET_TIMEOUT("metastore.client.socket.timeout",
"hive.metastore.client.socket.timeout", 600,
TimeUnit.SECONDS, "MetaStore Client socket timeout in seconds"),
+ CLIENT_CONNECTION_TIMEOUT("metastore.client.connection.timeout",
"hive.metastore.client.connection.timeout", 10,
Review Comment:
Yes, I have changed the default connectionTimeout to be the same as
socketTimeout. But IMHO it's not a good practice because if we set
socketTimeout and not set connectionTimeout, the default long time will be
gained for connection, I think we should change the behavior by default where
socketTimeout = connectionTimeout.
Issue Time Tracking
-------------------
Worklog Id: (was: 858987)
Time Spent: 2h (was: 1h 50m)
> Add the HMS client connection timeout config
> --------------------------------------------
>
> Key: HIVE-27172
> URL: https://issues.apache.org/jira/browse/HIVE-27172
> Project: Hive
> Issue Type: Task
> Components: Hive
> Reporter: Wechar
> Assignee: Wechar
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Currently {{HiveMetastoreClient}} use {{CLIENT_SOCKET_TIMEOUT}} as both
> socket timeout and connection timeout, it's not convenient for users to set a
> smaller connection timeout.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
