[ 
https://issues.apache.org/jira/browse/HIVE-27172?focusedWorklogId=859424&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-859424
 ]

ASF GitHub Bot logged work on HIVE-27172:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 27/Apr/23 15:13
            Start Date: 27/Apr/23 15:13
    Worklog Time Spent: 10m 
      Work Description: deniskuzZ commented on code in PR #4150:
URL: https://github.com/apache/hive/pull/4150#discussion_r1179316177


##########
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStoreTimeout.java:
##########
@@ -43,9 +46,10 @@ public class TestHiveMetaStoreTimeout {
   protected static HiveMetaStoreClient client;
   protected static Configuration conf;
   protected static Warehouse warehouse;
+  protected static int port;
 
-  @BeforeClass
-  public static void setUp() throws Exception {
+  @Before
+  public void setUp() throws Exception {
     HMSHandler.testTimeoutEnabled = true;

Review Comment:
   do we need to repeat the whole setup for every test or it's possible to 
extract just the HMSHandler part?





Issue Time Tracking
-------------------

    Worklog Id:     (was: 859424)
    Time Spent: 2h 20m  (was: 2h 10m)

> Add the HMS client connection timeout config
> --------------------------------------------
>
>                 Key: HIVE-27172
>                 URL: https://issues.apache.org/jira/browse/HIVE-27172
>             Project: Hive
>          Issue Type: Task
>          Components: Hive
>            Reporter: Wechar
>            Assignee: Wechar
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> Currently {{HiveMetastoreClient}} use {{CLIENT_SOCKET_TIMEOUT}} as both 
> socket timeout and connection timeout, it's not convenient for users to set a 
> smaller connection timeout.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to