[ 
https://issues.apache.org/jira/browse/HIVE-27243?focusedWorklogId=860659&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-860659
 ]

ASF GitHub Bot logged work on HIVE-27243:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/May/23 22:21
            Start Date: 04/May/23 22:21
    Worklog Time Spent: 10m 
      Work Description: aturoczy commented on code in PR #4289:
URL: https://github.com/apache/hive/pull/4289#discussion_r1185567260


##########
ql/src/java/org/apache/hadoop/hive/ql/parse/StorageFormat.java:
##########
@@ -38,7 +38,7 @@
 public class StorageFormat {
 
   private static final Logger LOG = 
LoggerFactory.getLogger(StorageFormat.class);
-  private static final StorageFormatFactory storageFormatFactory = new 
StorageFormatFactory();
+  public static final StorageFormatFactory storageFormatFactory = new 
StorageFormatFactory();

Review Comment:
   It is not better to expose via a getter method?  Like 
getStorageFromatFactory()





Issue Time Tracking
-------------------

    Worklog Id:     (was: 860659)
    Time Spent: 40m  (was: 0.5h)

> Iceberg: Implement Load data via temp table
> -------------------------------------------
>
>                 Key: HIVE-27243
>                 URL: https://issues.apache.org/jira/browse/HIVE-27243
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Ayush Saxena
>            Assignee: Ayush Saxena
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> Do a load data for iceberg via ingesting it to a temp table and then Insert 
> into/overwrite. (Impala Approach)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to