[
https://issues.apache.org/jira/browse/HIVE-27243?focusedWorklogId=861142&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-861142
]
ASF GitHub Bot logged work on HIVE-27243:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/May/23 08:16
Start Date: 09/May/23 08:16
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #4289:
URL: https://github.com/apache/hive/pull/4289#discussion_r1188292636
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -330,6 +333,15 @@ public boolean canProvideBasicStatistics() {
return true;
}
+ @Override
+ public StorageFormatDescriptor
supportsLoadData(org.apache.hadoop.hive.metastore.api.Table tbl) {
+ if (tbl.getParameters() != null) {
+ String format = tbl.getParameters().get("write.format.default");
+ return StorageFormat.getStorageFormatFactory().get(format == null ?
IOConstants.PARQUET : format);
Review Comment:
maybe you could extract below part from `processStorageFormat`
````
protected void processStorageFormat(String name) throws SemanticException {
if (name.isEmpty()) {
throw new SemanticException("File format in STORED AS clause cannot be
empty");
}
StorageFormatDescriptor descriptor = storageFormatFactory.get(name);
if (descriptor == null) {
throw new SemanticException("Unrecognized file format in STORED AS
clause:" +
" '" + name + "'");
}
````
Issue Time Tracking
-------------------
Worklog Id: (was: 861142)
Time Spent: 1h 50m (was: 1h 40m)
> Iceberg: Implement Load data via temp table
> -------------------------------------------
>
> Key: HIVE-27243
> URL: https://issues.apache.org/jira/browse/HIVE-27243
> Project: Hive
> Issue Type: Sub-task
> Reporter: Ayush Saxena
> Assignee: Ayush Saxena
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Do a load data for iceberg via ingesting it to a temp table and then Insert
> into/overwrite. (Impala Approach)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
