[
https://issues.apache.org/jira/browse/HIVE-27234?focusedWorklogId=861174&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-861174
]
ASF GitHub Bot logged work on HIVE-27234:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/May/23 10:23
Start Date: 09/May/23 10:23
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #4216:
URL: https://github.com/apache/hive/pull/4216#discussion_r1188448686
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/DDLUtils.java:
##########
@@ -217,4 +218,11 @@ public static void
setColumnsAndStorePartitionTransformSpecOfTable(
partCols.ifPresent(tbl::setPartCols);
}
}
+
+ public static void
validateTableIsIceberg(org.apache.hadoop.hive.ql.metadata.Table table)
Review Comment:
doesn't it duplicate `HiveTableOperations.validateTableIsIceberg`, could we
keep just one version of it
````
static void validateTableIsIceberg(Table table, String fullName) {
String tableType = table.getParameters().get(TABLE_TYPE_PROP);
NoSuchIcebergTableException.check(tableType != null &&
tableType.equalsIgnoreCase(ICEBERG_TABLE_TYPE_VALUE),
"Not an iceberg table: %s (type=%s)", fullName, tableType);
}
````
Issue Time Tracking
-------------------
Worklog Id: (was: 861174)
Time Spent: 9h 20m (was: 9h 10m)
> Iceberg: CREATE BRANCH SQL implementation
> ------------------------------------------
>
> Key: HIVE-27234
> URL: https://issues.apache.org/jira/browse/HIVE-27234
> Project: Hive
> Issue Type: Sub-task
> Components: Iceberg integration
> Reporter: zhangbutao
> Assignee: zhangbutao
> Priority: Major
> Labels: pull-request-available
> Time Spent: 9h 20m
> Remaining Estimate: 0h
>
> Maybe we can follow spark sql about branch ddl implementation
> [https://github.com/apache/iceberg/pull/6617]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
