[
https://issues.apache.org/jira/browse/HIVE-27234?focusedWorklogId=861221&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-861221
]
ASF GitHub Bot logged work on HIVE-27234:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/May/23 15:14
Start Date: 09/May/23 15:14
Worklog Time Spent: 10m
Work Description: zhangbutao commented on code in PR #4216:
URL: https://github.com/apache/hive/pull/4216#discussion_r1188764400
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/DDLUtils.java:
##########
@@ -217,4 +218,11 @@ public static void
setColumnsAndStorePartitionTransformSpecOfTable(
partCols.ifPresent(tbl::setPartCols);
}
}
+
+ public static void
validateTableIsIceberg(org.apache.hadoop.hive.ql.metadata.Table table)
Review Comment:
yep, it duplicates `HiveTableOperations.validateTableIsIceberg` as DDLTask
in`ql ` package can not import iceberg class.
I changed the thrown exception to` Not an iceberg table: %s (type=%s)` ,
this means the same thing as `HiveTableOperations.validateTableIsIceberg`
Issue Time Tracking
-------------------
Worklog Id: (was: 861221)
Time Spent: 9.5h (was: 9h 20m)
> Iceberg: CREATE BRANCH SQL implementation
> ------------------------------------------
>
> Key: HIVE-27234
> URL: https://issues.apache.org/jira/browse/HIVE-27234
> Project: Hive
> Issue Type: Sub-task
> Components: Iceberg integration
> Reporter: zhangbutao
> Assignee: zhangbutao
> Priority: Major
> Labels: pull-request-available
> Time Spent: 9.5h
> Remaining Estimate: 0h
>
> Maybe we can follow spark sql about branch ddl implementation
> [https://github.com/apache/iceberg/pull/6617]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
