[
https://issues.apache.org/jira/browse/HIVE-29747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18115479#comment-18115479
]
Stamatis Zampetakis commented on HIVE-29747:
--------------------------------------------
In the last successful CI run for the PR the compilation time was somewhat
higher than usual ("Total time: 53:09 min"):
[https://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-6618/5/pipeline/45]
I went over the logs but the overhead seems to be infrastructure related and
not relevant to the enablement of the Thrift module. A small extract from the
logs is attached in [^thrift-console.txt]
{noformat}
$ grep "(.*thrift.*)" pr6618-console.txt -A 10 -B 1 >
thrift-console.txt{noformat}
Most of the thrift specific goals finish in under a second so worst case it
would lead to 1-2 minute delay overall. I plan to merge the PR as is and if the
slowness persists I will open new Jira to investigate further.
> Add CI check to ensure Thrift code generation run
> -------------------------------------------------
>
> Key: HIVE-29747
> URL: https://issues.apache.org/jira/browse/HIVE-29747
> Project: Hive
> Issue Type: Task
> Components: Test
> Reporter: Stamatis Zampetakis
> Assignee: Stamatis Zampetakis
> Priority: Major
> Labels: pull-request-available
> Attachments: thrift-console.txt
>
>
> Various changes (e.g., HIVE-29184, HIVE-29699) require changes to .thrift
> files. Quite often contributors fail to execute the automatic Thrift code
> generator logic (via thriftif profile) leading to partial or broken Thrift
> implementations.
> The goal is to add a CI check (potentially in Jenkinsfile) so that every time
> that .thrift files are modified by a PR the check runs and ensures that the
> generated Thrift code is correct and complete. In other words, the content
> under src/gen/thrift directory matches the content of the pull request.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
