[
https://issues.apache.org/jira/browse/HIVE-29747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18116825#comment-18116825
]
Stamatis Zampetakis commented on HIVE-29747:
--------------------------------------------
For most recent CI runs on master (including this change) the compilation time
is normal (~30 minutes). For example, in the last run (as of now) the
compilation took "Total time: 27:17 min":
[https://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/master/3089/pipeline/39]
All in all, the compilation time divergence is entirely due to infrastructure
and completely unrelated with the Thrift compilation/validation. Based on the
recent runs the Thrift overhead is negligible.
> Add CI check to ensure Thrift code generation run
> -------------------------------------------------
>
> Key: HIVE-29747
> URL: https://issues.apache.org/jira/browse/HIVE-29747
> Project: Hive
> Issue Type: Task
> Components: Test
> Reporter: Stamatis Zampetakis
> Assignee: Stamatis Zampetakis
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.3.0
>
> Attachments: thrift-console.txt
>
>
> Various changes (e.g., HIVE-29184, HIVE-29699) require changes to .thrift
> files. Quite often contributors fail to execute the automatic Thrift code
> generator logic (via thriftif profile) leading to partial or broken Thrift
> implementations.
> The goal is to add a CI check (potentially in Jenkinsfile) so that every time
> that .thrift files are modified by a PR the check runs and ensures that the
> generated Thrift code is correct and complete. In other words, the content
> under src/gen/thrift directory matches the content of the pull request.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
