[ 
https://issues.apache.org/jira/browse/HIVE-12967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15133880#comment-15133880
 ] 

Gopal V commented on HIVE-12967:
--------------------------------

The patch seems to be skipping some fairly important entries from the 
hive-site.xml 

{code}
2016-02-05T04:13:04,842 WARN  [main[]]: impl.LlapDaemon 
(LlapDaemon.java:main(336)) - Failed to start LLAP Daemon with exception
java.lang.IllegalArgumentException: Work dirs must be specified
        at 
com.google.common.base.Preconditions.checkArgument(Preconditions.java:93) 
~[hive-exec-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
        at 
org.apache.hadoop.hive.llap.daemon.impl.LlapDaemon.<init>(LlapDaemon.java:108) 
~[hive-llap-server-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
        at 
org.apache.hadoop.hive.llap.daemon.impl.LlapDaemon.main(LlapDaemon.java:324) 
[hive-llap-server-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
{code}

{code}
+  public LlapDaemonConfiguration() {
+    super(false);
+    addResource(LLAP_DAEMON_SITE);
+  }
{code}

is not sufficient to pick up core-site.xml or yarn-site.xml shipped along-side.

> Change LlapServiceDriver to read a properties file instead of llap-daemon-site
> ------------------------------------------------------------------------------
>
>                 Key: HIVE-12967
>                 URL: https://issues.apache.org/jira/browse/HIVE-12967
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Siddharth Seth
>            Assignee: Siddharth Seth
>         Attachments: HIVE-12967.01.patch, HIVE-12967.1.wip.txt
>
>
> Having a copy of llap-daemon-site on the client node can be quite confusing, 
> since LlapServiceDriver generates the actual llap-daemon-site used by daemons.
> Instead of this - base settings can be picked up from a properties file.
> Also add java_home as a parameter to the script.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to