[
https://issues.apache.org/jira/browse/HIVE-12967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15142311#comment-15142311
]
Siddharth Seth commented on HIVE-12967:
---------------------------------------
I'm good with the updated patch and having the settings in hive-site.xml for
now; there's still scope for confusion since the llap specific properties like
cache size can be overridden by the service driver - in which case the values
are not indicative of what's actually being used in the daemon. It does make
overall deployment simpler as long as the name, ZK etc is not specified via
"--name" or "--hiveconf". No more pasting configs into hive-site.xml.
+1. Would be good to add a warning note on the --name and --hiveconf options on
potentially needing to copy parameters into hive-site.xml
In another jira, a llap-client config could be setup with the appropriate
information, daemon configs picked up from a template properties file, and
provided via command line to the script. llap-client would contain the name, ZK
address - for discovery, and any configs required in the AM to communicate with
LLAP. Would be nice if we could ship a metastore-client config file to LLAP
instead of the entire hive-site.
> Change LlapServiceDriver to read a properties file instead of llap-daemon-site
> ------------------------------------------------------------------------------
>
> Key: HIVE-12967
> URL: https://issues.apache.org/jira/browse/HIVE-12967
> Project: Hive
> Issue Type: Improvement
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Attachments: HIVE-12967.01.patch, HIVE-12967.1.wip.txt,
> HIVE-12967.2.patch
>
>
> Having a copy of llap-daemon-site on the client node can be quite confusing,
> since LlapServiceDriver generates the actual llap-daemon-site used by daemons.
> Instead of this - base settings can be picked up from a properties file.
> Also add java_home as a parameter to the script.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
