[
https://issues.apache.org/jira/browse/HIVE-13070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15159116#comment-15159116
]
Sergio Peña commented on HIVE-13070:
------------------------------------
Thanks. The patch looks good.
I was thinking if we can move the {{export BUILD_POSTFIX=...}} inside the
process_jira function, and also add a {{test -n "$BUILD_TAG" ...}} at the
beginning of the process_jira function. That way we only edit one file, and
process_jira will not depend on BUILD_POSTFIX to be set from whoever makes the
process_jira call.
> Precommit HMS tests should run in addition to precommit normal tests, not
> instead of
> ------------------------------------------------------------------------------------
>
> Key: HIVE-13070
> URL: https://issues.apache.org/jira/browse/HIVE-13070
> Project: Hive
> Issue Type: Bug
> Components: Testing Infrastructure
> Affects Versions: 2.1.0
> Reporter: Jesus Camacho Rodriguez
> Assignee: Jesus Camacho Rodriguez
> Attachments: HIVE-13070.patch
>
>
> When a certain patch makes changes in the metastore upgrade scripts folder,
> precommit HMS tests are triggered. The problem is that precommit HMS marks
> the patch as tested, thus normal precommit tests are never triggered.
> I hit the issue while testing HIVE-12994.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
