[ 
https://issues.apache.org/jira/browse/HIVE-13070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15159261#comment-15159261
 ] 

Jesus Camacho Rodriguez commented on HIVE-13070:
------------------------------------------------

[~spena], thanks for checking.

The problem with the change you proposed is that process\_jira is called in 
_jenkins-submit-build.sh_ script too, before the call to the tests execution is 
done: at that point, {{BUILD_TAG}} is not set, and hence {{BUILD_POSTFIX}} 
cannot be either. Thus, we cannot add {{test -n}}.

Nevertheless, I have uploaded a new patch to derive {{build_postfix}} within 
process\_jira iff {{BUILD_TAG}} is set.

> Precommit HMS tests should run in addition to precommit normal tests, not 
> instead of
> ------------------------------------------------------------------------------------
>
>                 Key: HIVE-13070
>                 URL: https://issues.apache.org/jira/browse/HIVE-13070
>             Project: Hive
>          Issue Type: Bug
>          Components: Testing Infrastructure
>    Affects Versions: 2.1.0
>            Reporter: Jesus Camacho Rodriguez
>            Assignee: Jesus Camacho Rodriguez
>         Attachments: HIVE-13070.01.patch, HIVE-13070.patch
>
>
> When a certain patch makes changes in the metastore upgrade scripts folder, 
> precommit HMS tests are triggered. The problem is that precommit HMS marks 
> the patch as tested, thus normal precommit tests are never triggered.
> I hit the issue while testing HIVE-12994.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to