[
https://issues.apache.org/jira/browse/HIVE-12634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15243859#comment-15243859
]
Eugene Koifman commented on HIVE-12634:
---------------------------------------
1. did you figure out why there are so many changes in generated code and if
it's a reason for concern?
2. I think that the new _TxnHandler.abortTxns(AbortTxnsRequest rqst)_ should
best effort, i.e. if the parameter list is 10 txn ids but for some reason it
only aborted 7 that should be ok. _abortTxns(Connection dbConn, List<Long>
txnids, long max_heartbeat)_ is too restrictive as currently implemented. It
should only bail when it didn't find all requested txn ids in some case.
3. HIVE-12439 introduced a bad bug in _abortTxns(Connection dbConn, List<Long>
txnids, long max_heartbeat)_. It changed how
{noformat}
updateCnt = stmt.executeUpdate(query);
if (updateCnt < txnids.size()) {
}
{noformat}
works. Now the 'if' statement will be true every time
_buildQueryWithINClause()_ produces > 1 query.
> Add command to kill an ACID transacton
> --------------------------------------
>
> Key: HIVE-12634
> URL: https://issues.apache.org/jira/browse/HIVE-12634
> Project: Hive
> Issue Type: New Feature
> Components: Transactions
> Affects Versions: 1.0.0
> Reporter: Eugene Koifman
> Assignee: Wei Zheng
> Attachments: HIVE-12634.1.patch, HIVE-12634.2.patch
>
>
> Should add a CLI command to abort a (runaway) transaction.
> This should clean up all state related to this txn.
> The initiator of this (if still alive) will get an error trying to
> heartbeat/commit, i.e. will become aware that the txn is dead.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
