[
https://issues.apache.org/jira/browse/HIVE-14608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15472061#comment-15472061
]
Gopal V commented on HIVE-14608:
--------------------------------
[~sershe]: I think the original loop was written with the assumption that
.canAcceptTask() can flip to true at some point during the loop.
That is probably a bad assumption now that we are running things in
milliseconds - LGTM +1.
> LLAP: slow scheduling due to LlapTaskScheduler not removing nodes on kill
> --------------------------------------------------------------------------
>
> Key: HIVE-14608
> URL: https://issues.apache.org/jira/browse/HIVE-14608
> Project: Hive
> Issue Type: Bug
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Priority: Critical
> Attachments: HIVE-14608.patch
>
>
> See comments; this can result in a slowdown esp. if some critical task gets
> unlucky.
> {noformat}
> public void workerNodeRemoved(ServiceInstance serviceInstance) {
> // FIXME: disabling this for now
> // instanceToNodeMap.remove(serviceInstance.getWorkerIdentity());
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
