[
https://issues.apache.org/jira/browse/HIVE-14608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15485383#comment-15485383
]
Siddharth Seth commented on HIVE-14608:
---------------------------------------
The expectation was that canAcceptTask will return a false if the node is not
available (as a result of serviceInstance.isAlive()). That is apparently not
happening when a node goes away. The current patch works; however I think it's
better to ensure the isAlive method on the ServiceInstance works as it should
(public api and all that).
> LLAP: slow scheduling due to LlapTaskScheduler not removing nodes on kill
> --------------------------------------------------------------------------
>
> Key: HIVE-14608
> URL: https://issues.apache.org/jira/browse/HIVE-14608
> Project: Hive
> Issue Type: Bug
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Priority: Critical
> Fix For: 2.2.0, 2.1.1
>
> Attachments: HIVE-14608.patch
>
>
> See comments; this can result in a slowdown esp. if some critical task gets
> unlucky.
> {noformat}
> public void workerNodeRemoved(ServiceInstance serviceInstance) {
> // FIXME: disabling this for now
> // instanceToNodeMap.remove(serviceInstance.getWorkerIdentity());
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
